mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 54167: Removed cyclic header dependency in libprocess.
Date Tue, 29 Nov 2016 19:16:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54167/#review157301
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54167]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 29, 2016, 3:59 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54167/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 3:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6647
>     https://issues.apache.org/jira/browse/MESOS-6647
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `executor.hpp` doesn't need anything from `defer.hpp` but defines a macro that is used
in it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/executor.hpp 48c1b34b6bd117653c1728321cf96b909e535964

> 
> Diff: https://reviews.apache.org/r/54167/diff/
> 
> 
> Testing
> -------
> 
> ```
> make && make check
> ```
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message