-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53627/#review157294
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/namespaces/uts.cpp (lines 70 - 79)
<https://reviews.apache.org/r/53627/#comment227830>
Wouldn't this conflict with what we are doing in the `network/cni` isolator. For containers
with a `NetworkInfo` we end up creating a new UTS namespace in the `network/cni` isolator.
More importantly the isolator sets the hostname to the `ContianerID` and also sets this information
up in `/etc/hosts` for DNS to resolve correctly.
Since the `network/cni` isolator is enabled by default, this would end up conflicting
with the UTS isolator.
- Avinash sridharan
On Nov. 28, 2016, 5:07 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53627/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 5:07 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-6556
> https://issues.apache.org/jira/browse/MESOS-6556
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implement a very simple namespaces/uts isolator that can be used to set
> the hostname and domainname of a container without the necessity of a
> CNI plugin.
>
> Since we already had a `hostname` field in the ContainerInfo, we can
> use that to set the host name once we are in the UTS namespace. Add a
> corresponding `domainname` to the ContainerInfo to allow setting the
> domain name.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05
> include/mesos/slave/containerizer.proto 2621522ae59cf9275f607679b4678ac54508993d
> src/Makefile.am 85eda538caf39f81f052896e744b7b0c724f81bb
> src/cli/execute.cpp ddf7ecac21f2680c3027fafeb4194a2dd4a66d47
> src/slave/containerizer/mesos/containerizer.cpp 9b33495d9babc3ee489a8712fe1977746c41043f
> src/slave/containerizer/mesos/isolators/namespaces/uts.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/namespaces/uts.cpp PRE-CREATION
> src/slave/containerizer/mesos/launch.hpp 155e3c5a27b8c710971ee4b508600d3b5589a2e0
> src/slave/containerizer/mesos/launch.cpp 320e42748adbabf09f77cb4f5951e2a7ea58fe64
> src/tests/containerizer/isolator_tests.cpp 9766aaf144722b18d88f694ff37ffd53974cb60d
>
> Diff: https://reviews.apache.org/r/53627/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> James Peach
>
>
|