mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 53982: Added documentation for posix/rlimit isolator.
Date Tue, 29 Nov 2016 12:54:47 GMT


> On Nov. 28, 2016, 8:36 p.m., Neil Conway wrote:
> > docs/posix_rlimits.md, line 48
> > <https://reviews.apache.org/r/53982/diff/1/?file=1568598#file1568598line48>
> >
> >     s/In addition many limits defined on Linux/Linux defines a number of additional
resource limits that are not included in the POSIX standard. These are also supported by this
isolator; see the definition of `RLimitInfo::RLimit` for the list of currently exposed types."
> >     
> >     Is there a reason to not include all the rlimit types in this document? The
list is probably not going to change very often.

I expanded the current list inline. The original motivation was to avoid duplication information
(which could go out of sync), but in the end we should make the documentation as useful as
possible.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53982/#review157091
-----------------------------------------------------------


On Nov. 29, 2016, 1:54 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53982/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 1:54 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-6427
>     https://issues.apache.org/jira/browse/MESOS-6427
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for posix/rlimit isolator.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-containerizer.md 2bff35f6361f760a9001a249d2c01bbbc9e72932 
>   docs/posix_rlimits.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53982/diff/
> 
> 
> Testing
> -------
> 
> Tested with github markdown renderer, and with build setup from `site/`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message