mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 54115: Added an http::serve abstraction.
Date Tue, 29 Nov 2016 02:47:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54115/#review157184
-----------------------------------------------------------




3rdparty/libprocess/include/process/http.hpp (lines 898 - 902)
<https://reviews.apache.org/r/54115/#comment227620>

    I'm going to remove this for now.



3rdparty/libprocess/src/tests/http_tests.cpp (line 1815)
<https://reviews.apache.org/r/54115/#comment227618>

    Add a TODO here. Suggestions:
    
    request.url = http::URL("http", address.path, 80, "/");
    
    request.url = http::URL("http", "", 80, "/");
    
    Which is still weird because it has port 80! So instead maybe a new URL overload that
takes an address and "does the right thing" for Unix Domain Sockets?


- Benjamin Hindman


On Nov. 28, 2016, 6:20 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54115/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 6:20 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an http::serve abstraction.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp a684e09c8353112a0656b7e899a469c1e022e93b

>   3rdparty/libprocess/src/http.cpp 3f16f293a5c5cd0b31a85efe94cb6f8019543d45 
>   3rdparty/libprocess/src/tests/http_tests.cpp d41929a9c8b2469c10b9e31985c447076c1684dc

> 
> Diff: https://reviews.apache.org/r/54115/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message