mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <>
Subject Re: Review Request 53849: Added parsing of V2 schema 2 Docker image manifests.
Date Mon, 28 Nov 2016 11:50:40 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 28, 2016, 11:50 a.m.)

Review request for mesos and Jie Yu.


Added new proto file to `src/CMakeLists.txt`.

Bugs: MESOS-3505

Repository: mesos


Added parsing of V2 schema 2 Docker image manifests.

Diffs (updated)

  include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03 
  include/mesos/docker/v2.hpp abab12b8f73564a6da1a0265a503d407a2849b3f 
  include/mesos/docker/v2_s2.proto PRE-CREATION 
  src/CMakeLists.txt d6e213686a44fbca0ed841594ce803151224a5a7 
  src/ dd1626d177b38a6613f18f32bb0668abbb5100e0 
  src/docker/spec.cpp 2f2c32e9b7d78debb31dcc1aa91a4d45c1ced192 
  src/tests/containerizer/docker_spec_tests.cpp 82bddd228df3db95a00eb277ff9c380039b70b1e 



Added tests to verify that V2 schema 2 image manifest can be successfully parsed and errors
like missing required fields or empty layers list are caught. Ran `make check`.


Ilya Pronin

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message