mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 54084: Made public Mesos header standalone.
Date Sat, 26 Nov 2016 00:53:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54084/#review156937
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54084]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 25, 2016, 4:53 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54084/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Missing includes were found by attempting to parse the header files
> standalone with
> 
>     $ clang++ -fsyntax-only -I .... HEADER_FILE.hpp
> 
> By fixing failures we can make sure that all required symbols are
> defined.
> 
> Note this change does not address the issue of transitive includes.
> 
> 
> Diffs
> -----
> 
>   include/mesos/appc/spec.hpp e9430df03b49f49d367e19b18991ead77fe5b830 
>   include/mesos/executor/executor.hpp 598d0106fe6c166507bde2bddfd7bed8d544da5a 
> 
> Diff: https://reviews.apache.org/r/54084/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X, clang trunk w/o optimizations, SSL)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message