mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 54083: Made headers in stout standalone.
Date Fri, 25 Nov 2016 22:58:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54083/#review156936
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54083]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 25, 2016, 4:53 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54083/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Missing includes were found by attempting to parse the header files
> standalone with
> 
>     $ clang++ -fsyntax-only -I .... HEADER_FILE.hpp
> 
> By fixing failures we can make sure that all required symbols are
> defined.
> 
> Note this change does not address the issue of transitive includes.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os.hpp bd085e4e29bbdb2d2baaaeff1d10c0bd95ca65ba 
>   3rdparty/stout/include/stout/os/osx.hpp 770c85d2a2569a4242d07b221f15a87565dd0bb5 
>   3rdparty/stout/include/stout/os/permissions.hpp 1fa7614878cb0f58270824c88ab0013a9d9f14e9

>   3rdparty/stout/include/stout/os/posix/socket.hpp 836e4b3c37435a7f952321a13f3193043c1055d9

>   3rdparty/stout/include/stout/os/posix/su.hpp c3ce87e35761ab8543051cd3fcc6f0188a61eae1

>   3rdparty/stout/include/stout/os/posix/xattr.hpp 518940fdffab38ad97cf229078c4494fa944e1d8

> 
> Diff: https://reviews.apache.org/r/54083/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X, clang trunk w/o optimizations, SSL)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message