mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 54084: Made public Mesos header standalone.
Date Fri, 25 Nov 2016 16:53:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54084/
-----------------------------------------------------------

Review request for mesos, Kevin Klues and Qian Zhang.


Repository: mesos


Description
-------

Missing includes were found by attempting to parse the header files
standalone with

    $ clang++ -fsyntax-only -I .... HEADER_FILE.hpp

By fixing failures we can make sure that all required symbols are
defined.

Note this change does not address the issue of transitive includes.


Diffs
-----

  include/mesos/appc/spec.hpp e9430df03b49f49d367e19b18991ead77fe5b830 
  include/mesos/executor/executor.hpp 598d0106fe6c166507bde2bddfd7bed8d544da5a 

Diff: https://reviews.apache.org/r/54084/diff/


Testing
-------

make check (OS X, clang trunk w/o optimizations, SSL)


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message