mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53950: Avoided hardcoding ports in some tests.
Date Fri, 25 Nov 2016 08:42:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53950/#review156898
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53948, 53986, 53949, 53950]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2016, 5:39 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53950/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2016, 5:39 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and haosdent huang.
> 
> 
> Bugs: MESOS-6618
>     https://issues.apache.org/jira/browse/MESOS-6618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Avoided hardcoding ports in some tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16

>   src/tests/health_check_tests.cpp 2c7022a1210ade6d7eb594c4f8934f2bdb2aee35 
> 
> Diff: https://reviews.apache.org/r/53950/diff/
> 
> 
> Testing
> -------
> 
> * `make check` (SSL build OS X clang trunk w/ optimizations; default build ubuntu-14.04
gcc-4.8.4 w/o optimizations)
> * tested with in-tree parallel test runner: `GTEST_FILTER='HealthCheckTest.*'  ~/src/mesos/support/mesos-gtest-runner.py
./mesos-tests` which would fail about for about 50% before this fix, and not measurably anymore
after.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message