mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 54013: Added user doc for nested container and task group.
Date Fri, 25 Nov 2016 08:27:14 GMT


> On Nov. 23, 2016, 10:41 p.m., Qian Zhang wrote:
> > docs/nested-container-and-task-group.md, line 166
> > <https://reviews.apache.org/r/54013/diff/1/?file=1568968#file1568968line166>
> >
> >     Indent, it seems a space is missed here.

Good catch, Qian.


> On Nov. 23, 2016, 10:41 p.m., Qian Zhang wrote:
> > docs/nested-container-and-task-group.md, line 209
> > <https://reviews.apache.org/r/54013/diff/1/?file=1568968#file1568968line209>
> >
> >     Currently we only support a single level of container nesting, right? If so,
then I think we may need to mention this limitation here, and also mention we will support
multiple level of container netsting in the section of `Future Work`.

We already supported the multi-level nested container. We have a simple unit test `ROOT_CGROUPS_LaunchNestedThreeLevels`
for three-level nested. Technically, arbitrary level nested up to 32 should work.


> On Nov. 23, 2016, 10:41 p.m., Qian Zhang wrote:
> > docs/nested-container-and-task-group.md, line 297
> > <https://reviews.apache.org/r/54013/diff/1/?file=1568968#file1568968line297>
> >
> >     Does this refer to multiple level of container nesting or something else?

The task group api is different from the nested container api. We may want to support launching
multiple task groups using `LaunchGroup` api in the future.


> On Nov. 23, 2016, 10:41 p.m., Qian Zhang wrote:
> > docs/nested-container-and-task-group.md, line 213
> > <https://reviews.apache.org/r/54013/diff/1/?file=1568968#file1568968line213>
> >
> >     I see here you have illustrated `NESTED_CONTAINER_LAUNCH` and `NESTED_CONTAINER_WAIT`,
do you want to illustrate  `NESTED_CONTAINER_KILL` too?

Thought about it before, but it depends on users whether or not to call `NESTED_CONTAINER_KILL
` from the executor. We already document `NESTED_CONTAINER_KILL` in previous section. This
workflow just simply shows a common case of a nested container's life cycle using the new
agent api.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review156819
-----------------------------------------------------------


On Nov. 22, 2016, 8:23 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 8:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
>     https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -----
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> -------
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message