mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 52869: Ensured command executor stops health checking terminated tasks.
Date Thu, 24 Nov 2016 17:27:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52869/#review156862
-----------------------------------------------------------




src/launcher/executor.cpp (line 624)
<https://reviews.apache.org/r/52869/#comment227190>

    I just realized that we now have a check, so the additional checks wouldn't lead to an
invalid transition.
    
    But still, if we don't stop the health checker here, it will still be working, even though
we'll throw away the results.


- Gastón Kleiman


On Nov. 23, 2016, 12:48 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52869/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2016, 12:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.
> 
> 
> Bugs: MESOS-5963
>     https://issues.apache.org/jira/browse/MESOS-5963
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp ce0b199551447504bb95743df4ce9ec4a0443cd4 
> 
> Diff: https://reviews.apache.org/r/52869/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message