mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <armand.gril...@gmail.com>
Subject Re: Review Request 50010: Added example framework for handling inverse offers.
Date Wed, 23 Nov 2016 14:24:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50010/#review156730
-----------------------------------------------------------




src/examples/inverse_offer_framework.cpp (line 529)
<https://reviews.apache.org/r/50010/#comment226995>

    `class Flags : public virtual flags::FlagsBase` in other frameworks.



src/examples/inverse_offer_framework.cpp (line 534)
<https://reviews.apache.org/r/50010/#comment226996>

    The format is `add(&Flags::role,` in other frameworks. Same for the other flags added.


Doing a `make check` with this patch on top of `master` did not work, modifying it following
the two comments above fixed the problem.

- Armand Grillet


On Sept. 16, 2016, 9:35 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50010/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 9:35 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Kevin Klues.
> 
> 
> Bugs: MESOS-5827
>     https://issues.apache.org/jira/browse/MESOS-5827
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This framework shows how one might handle inverse offers by launching
> persistent sleep tasks and migrating them ahead of planned maintenance.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 44fd8a216eb70d806f74b6f6acff69a2e55b7ede 
>   src/examples/inverse_offer_framework.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50010/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> TODO: Add a helper binary for generating random maintenance schedules.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message