mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 53541: Added authorization actions for debug API.
Date Wed, 23 Nov 2016 08:18:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53541/#review156709
-----------------------------------------------------------




include/mesos/authorizer/acls.proto (line 271)
<https://reviews.apache.org/r/53541/#comment226969>

    s/nested/a nested container/
    s/leve/level/



include/mesos/authorizer/acls.proto (line 278)
<https://reviews.apache.org/r/53541/#comment226973>

    s/nester/nested/



include/mesos/authorizer/acls.proto (lines 288 - 289)
<https://reviews.apache.org/r/53541/#comment226971>

    "Objects: The list of operating system users (e.g., linux users) a nested container (TTY)
session can be run as."



include/mesos/authorizer/acls.proto (lines 299 - 300)
<https://reviews.apache.org/r/53541/#comment226972>

    Objects: The operating system users (e.g. linux users) of the top-level containers under
which the principal may launch a nested container session.



include/mesos/authorizer/acls.proto (line 304)
<https://reviews.apache.org/r/53541/#comment226970>

    s/attach the input/attach to the input/ (same for output)



include/mesos/authorizer/acls.proto (line 326)
<https://reviews.apache.org/r/53541/#comment226974>

    Which principals are authorized to kill nested containers under a top-level container
whose executor was launched with the given user.



include/mesos/authorizer/acls.proto (line 331)
<https://reviews.apache.org/r/53541/#comment226975>

    Which principals are authorized to wait on nested containers under a top-level container
whose executor was launched with the given user.



include/mesos/authorizer/authorizer.proto (line 158)
<https://reviews.apache.org/r/53541/#comment226976>

    s/an/and/ (here and in LNC_SESSION)


- Adam B


On Nov. 22, 2016, 6:48 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53541/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 6:48 a.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Kevin Klues, and Till Toenshoff.
> 
> 
> Bugs: MESOS-6474
>     https://issues.apache.org/jira/browse/MESOS-6474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authorization actions for debug API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto e3fd6a4a1b617a75714ebd6e08ab10cffa1a7d1b 
>   include/mesos/authorizer/authorizer.hpp 3cd0f84e25c0ea91a6f20eba26341a1b830d8cf2 
>   include/mesos/authorizer/authorizer.proto 0696a629ac2d2b9950e20708f0c3666b58ff7ca0

>   src/authorizer/local/authorizer.cpp 77e05dd2475d6e7511e7c7eeea578ec31ff3d198 
>   src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474 
> 
> Diff: https://reviews.apache.org/r/53541/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message