mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 53491: Disabled tests relying on filtering HTTP events.
Date Tue, 22 Nov 2016 21:20:22 GMT


> On Nov. 22, 2016, 8:35 p.m., Benjamin Mahler wrote:
> > This didn't have a ship it, I was expecting the test filter changes to be in place
before we committed the changes. Are you working on these now?

Looks like there is some disconnect. We had an offline discussion at MesosCon China on this
and I remember you agreeing that we can commit these patches with the tests disabled and I
can work on the filtering changes in the interim. I have already filed an issue (blocker)
yesterday and would start working on it soon: https://issues.apache.org/jira/browse/MESOS-6623

I am happy to revert the patches if this is not what you had in mind.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53491/#review156625
-----------------------------------------------------------


On Nov. 22, 2016, 12:27 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53491/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 12:27 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6466
>     https://issues.apache.org/jira/browse/MESOS-6466
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some tests that rely on filtering HTTP events based on type won't
> work now since the request body is not yet known when `visit()`
> is invoked. These would be fixed as part of a separate JIRA
> issue.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp c8cd89228eb4e55c9a9655f9de39cb070e14520c 
>   src/tests/slave_recovery_tests.cpp 99c27399297e3b04af167029d200d8ac418af2a6 
> 
> Diff: https://reviews.apache.org/r/53491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message