mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.
Date Tue, 22 Nov 2016 19:55:41 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 22, 2016, 7:55 p.m.)

Review request for mesos, Joseph Wu and Vinod Kone.

Bugs: MESOS-3753

Repository: mesos


This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.


  3rdparty/libprocess/include/process/ssl/gtest.hpp 21a0fc45b55a368a21b3e616c751ab43eebd4902

  3rdparty/libprocess/src/tests/ssl_tests.cpp 55c8c309571b1892b0acc4d766eda9bb98085a6f 


Testing (updated)

Testing details are found at the end of this chain.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message