mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 52103: Implemented quota update through `PUT` method.
Date Tue, 22 Nov 2016 18:28:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52103/
-----------------------------------------------------------

(Updated Nov. 22, 2016, 6:28 p.m.)


Review request for mesos, Alexander Rukletsov and Xiaojian Huang.


Summary (updated)
-----------------

Implemented quota update through `PUT` method.


Bugs: MESOS-4941
    https://issues.apache.org/jira/browse/MESOS-4941


Repository: mesos


Description (updated)
-------

This patch implemented atomic quota update through
`PUT` methood on the `/quota` endpoint.

Changes included:
- a new virtual function on the allocator interface-
- implementation in hierarchical allocator;
- implementation in quota_handler;
- some integration tests for updating a quota.

More tests around complex quota behavior and operator API
implementation will be sent in later patches.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp 3fe04f8a4fb331defbe672c739df4e137bdb3627 
  src/master/allocator/mesos/allocator.hpp 61159a91700270b1aa6fb335b8a41592e03ef8a9 
  src/master/allocator/mesos/hierarchical.hpp 2c31471ee0f5d6836393bf87ff9ecfd8df835013 
  src/master/allocator/mesos/hierarchical.cpp 3b759494071c4cae4b8b7dbcb0028df4146fc30e 
  src/master/http.cpp 90cbed1ba411e18906fe9c26bc14576a26d1b7b9 
  src/master/master.hpp b6c610b79aab146ece6b9be59be86f283d1c9ee8 
  src/master/quota_handler.cpp 5578663f26d9b737499dc4f5a286c34c37645442 
  src/tests/allocator.hpp bce11904f0b8de66a6620b636321568fdc0d113f 
  src/tests/master_quota_tests.cpp 48be7406181646c8cc1d169b82a4a4ca71cdf03b 

Diff: https://reviews.apache.org/r/52103/diff/


Testing
-------


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message