mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 53804: Added a parameter to 'Socket::shutdown' to specify 'how'.
Date Tue, 22 Nov 2016 18:22:53 GMT


> On Nov. 21, 2016, 6:20 p.m., Benjamin Mahler wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, lines 332-334
> > <https://reviews.apache.org/r/53804/diff/1/?file=1564885#file1564885line332>
> >
> >     It looks like windows happens to define the same values as Linux for shutdown,
but with different macro names:
> >     
> >     ```
> >     // Windows:
> >     SD_RECEIVE = 0
> >     SD_SEND = 1
> >     SD_BOTH = 2
> >     
> >     // Linux:
> >     SHUT_RD = 0
> >     SHUT_WR = 1
> >     SHUT_RDWR = 2
> >     ```
> >     
> >     But it looks like POSIX only specifies that the macro names have to map to distinct
values, but doesn't seem to specify the values. After looking at how this works on windows
I noticed this:
> >     
> >     https://github.com/apache/mesos/blob/b5c11a2e84e0d9102e73148c0651d2d53fd22e56/3rdparty/stout/include/stout/windows.hpp#L170-L173
> >     
> >     Seems this should be updated to include `SHUT_WR` and `SHUT_RDWR` so that when
users pass these values it compiles on windows.

Awesome, thanks Ben! I added another patch here to edit the header: https://reviews.apache.org/r/53990/


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53804/#review156476
-----------------------------------------------------------


On Nov. 22, 2016, 6:22 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53804/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 6:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-5658 and MESOS-5966
>     https://issues.apache.org/jira/browse/MESOS-5658
>     https://issues.apache.org/jira/browse/MESOS-5966
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a parameter to 'Socket::shutdown' to specify 'how'.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f

> 
> Diff: https://reviews.apache.org/r/53804/diff/
> 
> 
> Testing
> -------
> 
> Testing details are found at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message