mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 53541: Added authorization actions for debug API.
Date Tue, 22 Nov 2016 14:47:15 GMT


> On Nov. 17, 2016, 10:44 a.m., Adam B wrote:
> > include/mesos/authorizer/acls.proto, lines 386-387
> > <https://reviews.apache.org/r/53541/diff/1-2/?file=1555492#file1555492line386>
> >
> >     Is this really proper indentation for a Mesos protobuf? Doesn't look like we've
had to wrap before..

I change it to the more traditional 4 spaces.


> On Nov. 17, 2016, 10:44 a.m., Adam B wrote:
> > include/mesos/authorizer/authorizer.proto, line 160
> > <https://reviews.apache.org/r/53541/diff/1-2/?file=1555493#file1555493line160>
> >
> >     Since LNC, KillNC, and WaitNC already exist, could you wire up the authorization
check for those Calls as a separate patch, so we can see how these fields will be filled in?

Will fix when everything is running properly.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53541/#review156189
-----------------------------------------------------------


On Nov. 21, 2016, 5:25 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53541/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 5:25 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Kevin Klues, and Till Toenshoff.
> 
> 
> Bugs: MESOS-6474
>     https://issues.apache.org/jira/browse/MESOS-6474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authorization actions for debug API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto e3fd6a4a1b617a75714ebd6e08ab10cffa1a7d1b 
>   include/mesos/authorizer/authorizer.hpp 3cd0f84e25c0ea91a6f20eba26341a1b830d8cf2 
>   include/mesos/authorizer/authorizer.proto 0696a629ac2d2b9950e20708f0c3666b58ff7ca0

>   src/authorizer/local/authorizer.cpp 77e05dd2475d6e7511e7c7eeea578ec31ff3d198 
>   src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474 
> 
> Diff: https://reviews.apache.org/r/53541/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message