mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53805: Updated libprocess test to use new 'Socket::shutdown' parameter.
Date Tue, 22 Nov 2016 09:44:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53805/#review156558
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53817, 53975, 53802, 50736, 51065, 52938, 50737, 53803, 50969, 50857, 53804,
53805]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 22, 2016, 7:12 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53805/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 7:12 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-5966
>     https://issues.apache.org/jira/browse/MESOS-5966
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates `HTTPTest.SocketEOF` to remove a sleep
> and make use of `Socket::shutdown` with the new `how`
> parameter.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/http_tests.cpp 533104c93dd1eaf67bf3752163d2e0cad090078d

> 
> Diff: https://reviews.apache.org/r/53805/diff/
> 
> 
> Testing
> -------
> 
> All testing was done on CentOS 7:
> 
> `make check` ran and all tests passed.
> 
> `3rdparty/libprocess/libprocess-tests --gtest_repeat=-1 --gtest_break_on_failure` ran
for several hundred repetitions with no failures.
> 
> `3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest.Endpoints/*" --gtest_repeat=-1
--gtest_break_on_failure` ran for about 10,000 repetitions without failing.
> 
> `bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure` ran for several hundred
repetitions with no failures.
> 
> `bin/mesos-tests.sh --gtest_filter="*SchedulerSSLTest*" --gtest_repeat=-1 --gtest_break_on_failure`
ran for about 2,000 repetitions without failing.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message