mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 53805: Updated libprocess test to use new 'Socket::shutdown' parameter.
Date Tue, 22 Nov 2016 07:12:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53805/
-----------------------------------------------------------

(Updated Nov. 22, 2016, 7:12 a.m.)


Review request for mesos, Benjamin Mahler and Joseph Wu.


Changes
-------

Updated description.


Bugs: MESOS-5966
    https://issues.apache.org/jira/browse/MESOS-5966


Repository: mesos


Description (updated)
-------

This patch updates `HTTPTest.SocketEOF` to remove a sleep
and make use of `Socket::shutdown` with the new `how`
parameter.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/http_tests.cpp 533104c93dd1eaf67bf3752163d2e0cad090078d 

Diff: https://reviews.apache.org/r/53805/diff/


Testing (updated)
-------

All testing was done on CentOS 7:

`make check` ran and all tests passed.

`3rdparty/libprocess/libprocess-tests --gtest_repeat=-1 --gtest_break_on_failure` ran for
several hundred repetitions with no failures.

`3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest.Endpoints/*" --gtest_repeat=-1
--gtest_break_on_failure` ran for about 10,000 repetitions without failing.

`bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure` ran for several hundred repetitions
with no failures.

`bin/mesos-tests.sh --gtest_filter="*SchedulerSSLTest*" --gtest_repeat=-1 --gtest_break_on_failure`
ran for about 2,000 repetitions without failing.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message