mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 53950: Avoided hardcoding ports in some tests.
Date Mon, 21 Nov 2016 20:37:26 GMT


> On Nov. 21, 2016, 8:01 p.m., Gastón Kleiman wrote:
> > `src/tests/containerizer/port_mapping_tests.cpp` also uses a hard-coded port (they
were the "inspiration" behind tht health check tests), I guess we should update those as well.

Thanks for the pointer, these tests look indeed problematic as well. Since fixing these seems
to be more involved, I created https://issues.apache.org/jira/browse/MESOS-6620 to track these
independently. We should still try to make sure that the infrastructure created in https://reviews.apache.org/r/53949/
is suitable for use cases in `port_mapping_tests.cpp`.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53950/#review156489
-----------------------------------------------------------


On Nov. 21, 2016, 7:15 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53950/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and haosdent huang.
> 
> 
> Bugs: MESOS-6618
>     https://issues.apache.org/jira/browse/MESOS-6618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Avoided hardcoding ports in some tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16

>   src/tests/health_check_tests.cpp 2c7022a1210ade6d7eb594c4f8934f2bdb2aee35 
> 
> Diff: https://reviews.apache.org/r/53950/diff/
> 
> 
> Testing
> -------
> 
> make check (SSL build OS X clang trunk w/ optimizations; default build ubuntu-14.04 gcc-4.8.4
w/o optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message