mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53759: CMake: Change libprocess to a shared library.
Date Mon, 21 Nov 2016 19:25:22 GMT


> On Nov. 17, 2016, 9:09 a.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/src/CMakeLists.txt, line 93
> > <https://reviews.apache.org/r/53759/diff/1/?file=1563860#file1563860line93>
> >
> >     Seems like this should be using `MESOS_DEFAULT_LIBRARY_LINKAGE`?

Nope, Mesos variables shouldn't be used in stout/libprocess.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53759/#review156214
-----------------------------------------------------------


On Nov. 14, 2016, 7:09 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53759/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 7:09 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to load modules that are themselves based on libprocess,
> we must link libprocess as a shared library.  Since modules are
> only supported on non-Windows platforms, this changes the default
> linking mode to SHARED on non-Windows.
> 
> This review replaces: https://reviews.apache.org/r/49924/
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/CMakeLists.txt d1547ef6a8762385f653d3824307727e4d0a7e71 
> 
> Diff: https://reviews.apache.org/r/53759/diff/
> 
> 
> Testing
> -------
> 
> cmake ..
> make
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message