mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 53804: Added a parameter to 'Socket::shutdown' to specify 'how'.
Date Mon, 21 Nov 2016 18:03:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53804/#review156474
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/include/process/socket.hpp (line 192)
<https://reviews.apache.org/r/53804/#comment226656>

    s/const//



3rdparty/libprocess/include/process/socket.hpp (lines 330 - 335)
<https://reviews.apache.org/r/53804/#comment226657>

    It seems a better default would be a full shutdown rather than a partial shutdown, want
to add a TODO for that?


- Benjamin Mahler


On Nov. 16, 2016, 1:24 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53804/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2016, 1:24 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-5658
>     https://issues.apache.org/jira/browse/MESOS-5658
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a parameter to the `Socket::shutdown` function
> which allows callers to specify whether they would like the
> read end, write end, or both ends of the socket to be shutdown.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f

> 
> Diff: https://reviews.apache.org/r/53804/diff/
> 
> 
> Testing
> -------
> 
> Testing details are found at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message