mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 53573: Added the kill policy test helper.
Date Mon, 21 Nov 2016 13:00:52 GMT


> On Nov. 19, 2016, 4:01 a.m., Alexander Rukletsov wrote:
> > src/tests/kill_policy_test_helper.cpp, line 60
> > <https://reviews.apache.org/r/53573/diff/1/?file=1556666#file1556666line60>
> >
> >     You don't use `os::sleep` on purpose?

I thought that the nanosecond precision would be a bit of overkill for a simple test helper,
but it doesn't really hurt so I changed it.


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53573/#review156379
-----------------------------------------------------------


On Nov. 21, 2016, 12:59 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53573/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 12:59 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a test helper to facilitate the testing of `KillPolicy`.
> 
> The helper blocks until it receives a SIGTERM, then sleeps for a
> configurable amount of time before finally returning EXIT_SUCCESS.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac 
>   src/tests/CMakeLists.txt cf583ea3f10482b510459fb11a7ecaf76e498391 
>   src/tests/kill_policy_test_helper.hpp PRE-CREATION 
>   src/tests/kill_policy_test_helper.cpp PRE-CREATION 
>   src/tests/test_helper_main.cpp 42a8ec675500cb7b155823a4ea64d70a3481eaf4 
> 
> Diff: https://reviews.apache.org/r/53573/diff/
> 
> 
> Testing
> -------
> 
> `make check` (macOS and Debian)
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message