mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 53574: Made `CommandExecutorTest.NoTransitionFromKillingToRunning` more robust.
Date Mon, 21 Nov 2016 13:00:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53574/
-----------------------------------------------------------

(Updated Nov. 21, 2016, 1 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
-------

Addressed feedback.


Repository: mesos


Description
-------

This patch makes the test use the newly introduced test helper, instead
of the more fragile `trap` shell built-in.


Diffs (updated)
-----

  src/tests/command_executor_tests.cpp 62a09bd17152540bad658c7c3583ee7239f435f5 

Diff: https://reviews.apache.org/r/53574/diff/


Testing
-------

`make check` (macOS and Debian)


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message