-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53837/#review156426
-----------------------------------------------------------
Bad review!
Reviews applied: [53837, 53936, 53704, 53462, 53461, 53460, 53492, 53459, 53458, 53457]
Error:
Circular dependency detected for review 53462.Please fix the 'depends_on' field.
- Mesos ReviewBot
On Nov. 20, 2016, 9:27 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53837/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2016, 9:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-6467
> https://issues.apache.org/jira/browse/MESOS-6467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently, this process simply intercepts the stdout/stderr of a
> container and writes it to the stdout/stderr FDs set up by the
> container logger. We also send the stdout/stderr data to a simple HTTP
> server that we launch on a unix domain socket set up by the agent.
> Right now this server is just a stub and doesn't do anything useful.
>
> In future commits, we will expand this HTTP server to handle
> 'ATTACH_CONTAINER_INPUT' and 'ATTACH_CONTAINER_OUTPUT' calls on behalf
> of a container. It will use the stdout/stderr messages passed to it to
> and send that data over the response stream to any clients connected
> with an 'ATTACH_CONTAINER_OUTPUT' call. Likewise, it will take any
> input streamed in over a 'ATTACH_CONTAINER_INPUT' request and write it
> to a container's stdin.
>
> We don't currently handle recovering access to the io switchboard
> server process after agent restarts. We will add that in a subsequent
> commit.
>
>
> Diffs
> -----
>
> src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac
> src/slave/containerizer/mesos/containerizer.cpp ec4ae32485a7ab6c9f73c512004d1220482a188e
> src/slave/containerizer/mesos/io_switchboard/io_switchboard.hpp PRE-CREATION
> src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp PRE-CREATION
> src/slave/containerizer/mesos/io_switchboard/main.hpp PRE-CREATION
> src/slave/containerizer/mesos/io_switchboard/main.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53837/diff/
>
>
> Testing
> -------
>
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
>
>
> Thanks,
>
> Kevin Klues
>
>
|