mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 53610: Added health checks documentation.
Date Sun, 20 Nov 2016 18:51:06 GMT


> On Nov. 10, 2016, 2:44 p.m., Gastón Kleiman wrote:
> > docs/health-checks.md, line 49
> > <https://reviews.apache.org/r/53610/diff/1/?file=1559478#file1559478line49>
> >
> >     "an executor knows what a task means"?

Will kill that phrase entirely.


> On Nov. 10, 2016, 2:44 p.m., Gastón Kleiman wrote:
> > docs/health-checks.md, line 67
> > <https://reviews.apache.org/r/53610/diff/1/?file=1559478#file1559478line67>
> >
> >     s/docker/Docker/g

I'll do that only for "Docker container" and not for "docker executor".


> On Nov. 10, 2016, 2:44 p.m., Gastón Kleiman wrote:
> > docs/health-checks.md, line 130
> > <https://reviews.apache.org/r/53610/diff/1/?file=1559478#file1559478line130>
> >
> >     Same as in the previous case, it might be clearer to say that it will always
enter the task's net ns.

We does not always enter, but we always are.


> On Nov. 10, 2016, 2:44 p.m., Gastón Kleiman wrote:
> > docs/health-checks.md, line 238
> > <https://reviews.apache.org/r/53610/diff/1/?file=1559478#file1559478line238>
> >
> >     s/^/by /

Huh?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53610/#review155565
-----------------------------------------------------------


On Nov. 9, 2016, 5:05 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53610/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 5:05 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, Neil Conway, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5597
>     https://issues.apache.org/jira/browse/MESOS-5597
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md PRE-CREATION 
>   docs/home.md a5811480de050352dca6c0f7e4e64d3d2351c2d5 
> 
> Diff: https://reviews.apache.org/r/53610/diff/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/rukletsov/7200c36b2fd1e81f78f2583e68b31fd1
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message