mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 52873: Cleaned up private members in HealthChecker class.
Date Sat, 19 Nov 2016 09:47:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52873/#review156395
-----------------------------------------------------------


Ship it!





src/health-check/health_checker.hpp (line 141)
<https://reviews.apache.org/r/52873/#comment226613>

    Maybe instead a comment on why we need the launcher dir?


- Benjamin Mahler


On Nov. 14, 2016, 10:30 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52873/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 10:30 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.hpp a1dc72493ff31b87068d5691f4d5b794392caf76 
>   src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 
> 
> Diff: https://reviews.apache.org/r/52873/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message