-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52872/#review156394
-----------------------------------------------------------
Ship it!
Maybe add a TODO to replace the callback with a `process::Stream<HealthUpdate>`?
- Benjamin Mahler
On Nov. 14, 2016, 10:30 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52872/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2016, 10:30 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, and haosdent
huang.
>
>
> Bugs: MESOS-6395
> https://issues.apache.org/jira/browse/MESOS-6395
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since HealthChecker is now used as a library only and does not live
> in a separate OS process, there is no need to use libprocess message
> sending for health status updates; a callback will do.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562
> src/health-check/health_checker.hpp a1dc72493ff31b87068d5691f4d5b794392caf76
> src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b
> src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf
> src/launcher/executor.cpp ce0b199551447504bb95743df4ce9ec4a0443cd4
>
> Diff: https://reviews.apache.org/r/52872/diff/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/52873/.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
|