mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 53837: Added a per container mesos-io-switchboard process.
Date Fri, 18 Nov 2016 17:43:02 GMT


> On Nov. 18, 2016, 3:28 p.m., Gastón Kleiman wrote:
> > src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp, line 38
> > <https://reviews.apache.org/r/53837/diff/2/?file=1566652#file1566652line38>
> >
> >     shouldn't this include be the first one in the file?
> 
> Kevin Klues wrote:
>     We typically don't do that.
>     We always put headers in the order:
>     
>     1) C  headers like <signal.h>, <stdlib.h>, etc.
>     2) C++ library headers like <set>, <list>, <map>, etc.
>     3) Mesos external headers like <mesos/mesos.hpp>, <mesos/docker/v2.pb.h>,
etc.
>     4) Mesos internal headers like the file above.
>     
>     Within each category we group files at the same path depth alphabetically, and separate
each group by a blank line.

The Mesos and the Google C++ style guide say that the "related header" goes first:

> Use standard order for readability and to avoid hidden dependencies: Related header,
C library, C++ library, other libraries' .h, your project's .h. (https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes)

And in the "Order of includes" example in http://mesos.apache.org/documentation/latest/c++-style-guide/


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53837/#review156294
-----------------------------------------------------------


On Nov. 18, 2016, 5:07 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53837/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2016, 5:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6467
>     https://issues.apache.org/jira/browse/MESOS-6467
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently, this process simply intercepts the stdout/stderr of a
> container and writes it to the stdout/stderr FDs set up by the
> container logger. In future commits, this process will be expanded to
> allow dynamically attaching new input / output sources to a container
> to support `docker attach` like functionality for a running container.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac 
>   src/slave/containerizer/mesos/containerizer.cpp ec4ae32485a7ab6c9f73c512004d1220482a188e

>   src/slave/containerizer/mesos/io_switchboard/io_switchboard.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/io_switchboard/main.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/io_switchboard/main.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53837/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message