mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 53327: CMake: Added build variables for Mesos tests.
Date Thu, 17 Nov 2016 16:56:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53327/#review156211
-----------------------------------------------------------




src/tests/cmake/MesosTestsConfigure.cmake (lines 70 - 71)
<https://reviews.apache.org/r/53327/#comment226373>

    It's debatable, I think, whether we should be re-defining these for every test package.
It seems more likely that we want to put them in some common place, since we re-use them for
every test package. There's already some precedent for this because most lflags are defined
by stout configuration.


- Alex Clemmer


On Nov. 15, 2016, 3:08 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53327/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2016, 3:08 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The patch simply adds the mesos-tests target and renames the
> existing `TEST_HELPER_*` definitions to `MESOS_TEST_*`.
> The dependencies for the `test-helper` and the actual tests will
> be identical.
> 
> This review replaces: https://reviews.apache.org/r/49688/
> 
> 
> Diffs
> -----
> 
>   src/tests/CMakeLists.txt cf583ea3f10482b510459fb11a7ecaf76e498391 
>   src/tests/cmake/MesosTestsConfigure.cmake 3f543c010ae87ff04e6b45745bc49ef65b6590ff

> 
> Diff: https://reviews.apache.org/r/53327/diff/
> 
> 
> Testing
> -------
> 
> cmake ..
> make
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message