mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twitter.com>
Subject Review Request 53850: Implemented fetching Docker images that have V2 schema 2 manifests.
Date Thu, 17 Nov 2016 14:58:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53850/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-3505
    https://issues.apache.org/jira/browse/MESOS-3505


Repository: mesos


Description
-------

Implemented fetching Docker images that have V2 schema 2 manifests.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp b06ddff68a8d2df13abb838b03a8e73d4e273c31

  src/tests/containerizer/provisioner_docker_tests.cpp 96821692a8b2080a25997afa66a0b5e6699c95c4

  src/tests/uri_fetcher_tests.cpp 3c1bd33137612de90d65b7af288bb81ac9876c8b 
  src/uri/fetchers/docker.cpp 3f38dddfb4c089322fe4e13b1ef2070b4835885c 

Diff: https://reviews.apache.org/r/53850/diff/


Testing
-------

Added test to verify that V2 schema 2 image manifest can be pulled with all image blobs. Modified
previously added "pull image by digest" test to pull an image that has schema 2 manifest.
Ran `make check`.


Thanks,

Ilya Pronin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message