mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Review Request 53817: Added missing cleanup to libprocess `finalize()`.
Date Wed, 16 Nov 2016 19:07:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53817/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone.


Bugs: MESOS-5966
    https://issues.apache.org/jira/browse/MESOS-5966


Repository: mesos


Description
-------

The `finalize()` function in libprocess previously did
not delete the thread-local `Executor` which is used to
`defer` execution to an unspecified context. This object
must be deleted during finalization so that the
`__executor__` macro creates a new process if libprocess
is subsequently reinitialized.


Diffs
-----

  3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d 

Diff: https://reviews.apache.org/r/53817/diff/


Testing
-------

Testing details are found at the end of this review chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message