mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 53534: Added test `ReservationTest.PreventStealingFromAnotherRole`.
Date Wed, 16 Nov 2016 14:01:43 GMT


> On Nov. 16, 2016, 12:56 p.m., Alexander Rukletsov wrote:
> > src/tests/reservation_tests.cpp, lines 2399-2400
> > <https://reviews.apache.org/r/53534/diff/1/?file=1555456#file1555456line2399>
> >
> >     Probably `WillRepeatedly(Return()); // Ignore subsequent offers`

This is supposed to be the last offer.


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53534/#review156053
-----------------------------------------------------------


On Nov. 7, 2016, 2:26 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53534/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2016, 2:26 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test ensures that a framework can't use an `UNRESERVE` operation to
> steal resources reserved by a framework with another role.
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp 6c28ab4557f342134efce0ad7cb174a5adb4dc10 
> 
> Diff: https://reviews.apache.org/r/53534/diff/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh --gtest_filter='ReservationTest.PreventStealingFromAnotherRole' --break-on-error
--gtest_repeat=1000`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message