mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 53470: Added a test to ensure MESOS-6142 is fixed.
Date Wed, 16 Nov 2016 12:31:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53470/#review156049
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/reservation_tests.cpp (line 2114)
<https://reviews.apache.org/r/53470/#comment226179>

    Let's abolish slavery at least in variable names.



src/tests/reservation_tests.cpp (line 2159)
<https://reviews.apache.org/r/53470/#comment226182>

    Let's pull both roles as constants to the beginning of the test. And probably rename "yoyo"
(even though I like it personally) : ).



src/tests/reservation_tests.cpp (lines 2160 - 2161)
<https://reviews.apache.org/r/53470/#comment226181>

    Blank line.



src/tests/reservation_tests.cpp (lines 2166 - 2167)
<https://reviews.apache.org/r/53470/#comment226183>

    fits one line.


- Alexander Rukletsov


On Nov. 4, 2016, 12:52 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53470/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 12:52 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Michael Park.
> 
> 
> Bugs: MESOS-6142
>     https://issues.apache.org/jira/browse/MESOS-6142
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test ensures that frameworks can't reserve resources using a role
> different from the one they registered with.
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp 6c28ab4557f342134efce0ad7cb174a5adb4dc10 
> 
> Diff: https://reviews.apache.org/r/53470/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message