mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 53541: Added authorization actions for debug API.
Date Wed, 16 Nov 2016 09:29:43 GMT


> On Nov. 16, 2016, 7:14 a.m., Adam B wrote:
> > include/mesos/authorizer/authorizer.proto, lines 142-143
> > <https://reviews.apache.org/r/53541/diff/1/?file=1555493#file1555493line142>
> >
> >     What are these exceptional cases? What is an authorizer supposed to do with
no object metadata at all?

I could remove that, however, there could be cases where `user` is not set in any of the fields.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53541/#review156027
-----------------------------------------------------------


On Nov. 9, 2016, 1:43 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53541/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 1:43 a.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Kevin Klues, and Till Toenshoff.
> 
> 
> Bugs: MESOS-6474
>     https://issues.apache.org/jira/browse/MESOS-6474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authorization actions for debug API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto e3fd6a4a1b617a75714ebd6e08ab10cffa1a7d1b 
>   include/mesos/authorizer/authorizer.proto b6a9f142eecbdfd59210872a92e3126f04de334c

>   src/authorizer/local/authorizer.cpp f1dff65d973fc84f4171f68fd0391a2343a96965 
>   src/tests/authorization_tests.cpp 5d7e17b67821357b8cb538798acc883945c8f8fd 
> 
> Diff: https://reviews.apache.org/r/53541/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message