mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 53741: Display maintainance info in the webui.
Date Wed, 16 Nov 2016 08:18:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53741/#review156037
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/webui/master/static/js/app.js (lines 291 - 293)
<https://reviews.apache.org/r/53741/#comment226169>

    Got it, thank you! Let's use `if (!key)` to check if it is `undefined` or `null` here.
`key` may equal to `undefined`?



src/webui/master/static/js/controllers.js (line 469)
<https://reviews.apache.org/r/53741/#comment226170>

    Any reason that remove `pollState();` here?



src/webui/master/static/maintenance.html (line 6)
<https://reviews.apache.org/r/53741/#comment226166>

    `Maintenance Schedule`



src/webui/master/static/maintenance.html (line 23)
<https://reviews.apache.org/r/53741/#comment226171>

    `{{(window.unavailability.start.nanoseconds/1000000) | isoDate}}`



src/webui/master/static/maintenance.html (line 30)
<https://reviews.apache.org/r/53741/#comment226172>

    `{{machine_ids.hostname ? machine_ids.hostname : machine_ids.ip}}`


- haosdent huang


On Nov. 15, 2016, 9:03 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53741/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2016, 9:03 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Joseph Wu.
> 
> 
> Bugs: MESOS-6443
>     https://issues.apache.org/jira/browse/MESOS-6443
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Create new page with Maintenance schedule. Schedule is downloaded on
> page refresh. Schedule is not live like stats and tasks so there is
> no need to poll it periodically.
> Diable sorting when data-key is not defined in table header.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485 
>   src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382 
>   src/webui/master/static/js/controllers.js dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9

>   src/webui/master/static/maintenance.html PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53741/diff/
> 
> 
> Testing
> -------
> 
> [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png)
> 
> Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 entires schedule
generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message