mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 53624: Add a content type option to mesos-execute.
Date Wed, 16 Nov 2016 04:09:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53624/#review156021
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Nov. 11, 2016, 12:49 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53624/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6562
>     https://issues.apache.org/jira/browse/MESOS-6562
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using the JSON content type in mesos-execute makes packet tracing
> protocol interactions easier. Add a --content_type option that
> switched between protobuf (the default) and JSON content types.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp b47c427c5ad29dda1985ee8fef6c4efe054df879 
> 
> Diff: https://reviews.apache.org/r/53624/diff/
> 
> 
> Testing
> -------
> 
> make check. Manually verified with tcpdump.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message