mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 53057: Updates calls to the authorizer to use whole protobuf messages.
Date Wed, 16 Nov 2016 02:53:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53057/#review156016
-----------------------------------------------------------


Ship it!




Flawless.

- Adam B


On Nov. 7, 2016, 7:30 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53057/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2016, 7:30 a.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, and Till Toenshoff.
> 
> 
> Bugs: MESOS-6401
>     https://issues.apache.org/jira/browse/MESOS-6401
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Makes changes in the calls to the authorizer, so that it uses the
> new protobuf message based authorization calls when available.
> It still sets the traditional `Object.value` field for compatibility
> with old authorizers.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 
>   src/master/master.hpp 87186c6e733a686f96528b1722fda1c287e9c881 
>   src/master/master.cpp 15ad5a647fc71d36ffd149893b3b9448a7d99323 
>   src/master/quota_handler.cpp d87d6c6266ba596c4e6bd36124f5a360428fe171 
>   src/master/weights_handler.cpp c240fb2980a7e957136d11ddd3f43ee4761a07dc 
> 
> Diff: https://reviews.apache.org/r/53057/diff/
> 
> 
> Testing
> -------
> 
> Tests in the last patch of the series.
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message