mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 46229: Add unit tests for adding a user for persistent volumes.
Date Tue, 15 Nov 2016 20:55:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46229/#review155965
-----------------------------------------------------------




src/tests/containerizer/linux_filesystem_isolator_tests.cpp (lines 1527 - 1531)
<https://reviews.apache.org/r/46229/#comment226058>

    Could you expand this test to include both a successful and an unsuccessful attempt to
access the volume? We already make use of the user "nobody" in the agent tests, so we could
use it here as well.



src/tests/containerizer/linux_filesystem_isolator_tests.cpp (line 1532)
<https://reviews.apache.org/r/46229/#comment226057>

    Since this test doesn't use a shared volume, should probably remove "Shared" from the
test name?



src/tests/containerizer/linux_filesystem_isolator_tests.cpp (lines 1595 - 1596)
<https://reviews.apache.org/r/46229/#comment226056>

    This comment is incorrect, right? Looks like the task is successfully writing.



src/tests/persistent_volume_tests.cpp (lines 547 - 548)
<https://reviews.apache.org/r/46229/#comment226059>

    Could you include a short comment preceding the test which explains the test's purpose?



src/tests/persistent_volume_tests.cpp (line 587)
<https://reviews.apache.org/r/46229/#comment226060>

    Perhaps to more comprehensively verify the intended behavior here, you could create the
volume as the "nobody" user and check the volume's owner after the directory has been created.


- Greg Mann


On Oct. 18, 2016, 7:46 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46229/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2016, 7:46 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
>     https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add unit tests for adding a user for persistent volumes.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp f17ed4437a5e1366f85803ce7e29bee24162504c

>   src/tests/hierarchical_allocator_tests.cpp 2e979d784b8e6cdacebac78a67498b5f4d023540

>   src/tests/master_validation_tests.cpp da43f990e3b8f61e27b22d551cd3e07638c7ff37 
>   src/tests/mesos.hpp 9309b5a985c0d7136a2ee5aa1598b4fee6194816 
>   src/tests/persistent_volume_tests.cpp 6289009fe9ed0a57ba5eff46dbbe0633a75d2616 
>   src/tests/resources_tests.cpp 6a12783c26f359dda835b4866b299a8fcfb3f972 
>   src/tests/sorter_tests.cpp 1f17c011898836ea9159661dde7d544cb0d8ea83 
> 
> Diff: https://reviews.apache.org/r/46229/diff/
> 
> 
> Testing
> -------
> 
> All tests passed (including the newly added tests).
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message