mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 53760: CMake: Changed example module output location and depedencies.
Date Tue, 15 Nov 2016 03:10:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53760/
-----------------------------------------------------------

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
    https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
-------

This moves some test libraries from the default CMake build
output locations to `<build_dir>/src/.libs`, which is where
the Automake build outputs libraries.  We have a few tests
that expect modules to be located in this directory.

Additionally, this makes the test target (make check) depend
on the test modules and example frameworks, so that they are built
in the correct order.


Diffs
-----

  src/examples/CMakeLists.txt PRE-CREATION 
  src/slave/container_loggers/CMakeLists.txt PRE-CREATION 
  src/slave/qos_controllers/CMakeLists.txt 87c92af21c012655c201c01cd4ba5ff912555119 
  src/slave/resource_estimators/CMakeLists.txt 17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 
  src/tests/CMakeLists.txt cf583ea3f10482b510459fb11a7ecaf76e498391 

Diff: https://reviews.apache.org/r/53760/diff/


Testing
-------

cmake ..
make clean
make


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message