mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 53759: CMake: Change libprocess to a shared library.
Date Tue, 15 Nov 2016 03:09:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53759/
-----------------------------------------------------------

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
    https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
-------

In order to load modules that are themselves based on libprocess,
we must link libprocess as a shared library.  Since modules are
only supported on non-Windows platforms, this changes the default
linking mode to SHARED on non-Windows.

This review replaces: https://reviews.apache.org/r/49924/


Diffs
-----

  3rdparty/libprocess/src/CMakeLists.txt d1547ef6a8762385f653d3824307727e4d0a7e71 

Diff: https://reviews.apache.org/r/53759/diff/


Testing
-------

cmake ..
make


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message