-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53741/#review155882
-----------------------------------------------------------
Patch looks great!
Reviews applied: [53741]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 14, 2016, 9:27 p.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53741/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2016, 9:27 p.m.)
>
>
> Review request for mesos, haosdent huang and Joseph Wu.
>
>
> Bugs: MESOS-6443
> https://issues.apache.org/jira/browse/MESOS-6443
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Create new page with Maintenance schedule. Schedule is downloaded on
> page refresh. Schedule is not live like stats and tasks so there is
> no need to poll it periodically.
> Diable sorting when data-key is not defined in table header.
>
>
> Diffs
> -----
>
> src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485
> src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382
> src/webui/master/static/js/controllers.js dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9
> src/webui/master/static/maintenance.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53741/diff/
>
>
> Testing
> -------
>
> [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png)
>
> Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 entires schedule
generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853)
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
|