mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 53532: Added parse helper function to 'Docker::Device'.
Date Sat, 12 Nov 2016 12:26:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53532/#review155778
-----------------------------------------------------------



Summary:
```
Added `parse` helper function for `Docker::Device`.
```

Description:
```
Added a new helper function to parse a string to 'Docker::Device'
'Docker::Device' structure. The string should be in the format of
`PathInHost:PathInContainer:Permission`.
```


src/docker/docker.hpp (line 71)
<https://reviews.apache.org/r/53532/#comment225865>

    How about adding a comment here?
    
    ```
    // Parse a string to docker device, the string should be 
    // in the format of `PathInHost:PathInContainer:Permission`.
    ```


- Guangya Liu


On 十一月 10, 2016, 8:14 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53532/
> -----------------------------------------------------------
> 
> (Updated 十一月 10, 2016, 8:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper function to parse string input to 'Docker::Device'
> structure.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
> 
> Diff: https://reviews.apache.org/r/53532/diff/
> 
> 
> Testing
> -------
> 
> make -j4 check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message