mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error.
Date Fri, 11 Nov 2016 08:22:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53666/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jiang Yan Xu.


Bugs: MESOS-6489
    https://issues.apache.org/jira/browse/MESOS-6489


Repository: mesos


Description
-------

Added a `continueOnError` attribute to cgroups `Destroyer` to allow
cgroups cleanup to continue incase of any error. The linux launcher
continues cleanup of cgroups even if there is an error. However, if
the top level cgroup is actually removed, it treats it as a success.


Diffs
-----

  src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d 
  src/linux/cgroups.cpp 630e2ec2d0eac2bb35488d0416883df1601224c8 
  src/slave/containerizer/mesos/linux_launcher.cpp 0305d14c1f791c93edcd3b32786b483b15f40a2d


Diff: https://reviews.apache.org/r/53666/diff/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message