mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 53485: Introduced a `readAll()` helper on `http::Pipe::Reader`.
Date Thu, 10 Nov 2016 23:44:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53485/#review155667
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/src/http.cpp (line 436)
<https://reviews.apache.org/r/53485/#comment225713>

    Should we do the following?
    
    ```
    return std::move(*buffer);
    ```
    
    This would allow us to move into the returned Future once there is a move constructor.



3rdparty/libprocess/src/tests/http_tests.cpp (line 415)
<https://reviews.apache.org/r/53485/#comment225715>

    Looking at the above tests (e.g. HTTPTest.PipeFailure), looks like you don't need the
string here? i.e.
    
    ```
    AWAIT_EXPECT_EQ("helloworld", readAll);
    ```


- Benjamin Mahler


On Nov. 10, 2016, 10:02 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53485/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2016, 10:02 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6466
>     https://issues.apache.org/jira/browse/MESOS-6466
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The helper reads from the pipe till EOF. This is used later to
> read BODY requests from the streaming request decoder.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 9722c6210526479da243ae9945e4c9a89ecb9009

>   3rdparty/libprocess/src/http.cpp b5ddac9f1970358f8232a481431507242052d294 
>   3rdparty/libprocess/src/tests/http_tests.cpp 533104c93dd1eaf67bf3752163d2e0cad090078d

> 
> Diff: https://reviews.apache.org/r/53485/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message