> On Nov. 5, 2016, 1:42 a.m., Benjamin Mahler wrote:
> > Nice commit summary! Would you mind adding a test alongside this? Should be pretty
straightforward to do.
Added.
> On Nov. 5, 2016, 1:42 a.m., Benjamin Mahler wrote:
> > 3rdparty/libprocess/include/process/io.hpp, line 100
> > <https://reviews.apache.org/r/53485/diff/1/?file=1554492#file1554492line100>
> >
> > Can you remove the const& here given that you need non-const access and
it's what you take in the actual `_read` implementation? As it stands the const may be a bit
misleading.
Dropping since its not relevant due to the function not being there anymore.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53485/#review155042
-----------------------------------------------------------
On Nov. 4, 2016, 5:55 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53485/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2016, 5:55 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6466
> https://issues.apache.org/jira/browse/MESOS-6466
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The helper reads from the pipe till EOF. This is used later to
> read BODY requests from the streaming request decoder.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/io.hpp eec5efd7e6b71a783f2bb40826054d0488cee71f
> 3rdparty/libprocess/src/io.cpp d930ceebc90468e082b984e41385549f906dc6ae
>
> Diff: https://reviews.apache.org/r/53485/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
|