mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 53610: Added health checks documentation.
Date Thu, 10 Nov 2016 14:44:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53610/#review155565
-----------------------------------------------------------



I am not a native speaker, so please take my suggestions with a grain of salt and feel free
to drop them =).


docs/health-checks.md (line 13)
<https://reviews.apache.org/r/53610/#comment225556>

    s/in a way/in the way/



docs/health-checks.md (line 32)
<https://reviews.apache.org/r/53610/#comment225566>

    s/docker/Docker/



docs/health-checks.md (line 34)
<https://reviews.apache.org/r/53610/#comment225567>

    s/only is/, but is/



docs/health-checks.md (line 43)
<https://reviews.apache.org/r/53610/#comment225568>

    Is `HealthCheck` here supposed to be a link to the protobuf



docs/health-checks.md (line 45)
<https://reviews.apache.org/r/53610/#comment225569>

    s/only/only the/



docs/health-checks.md (line 49)
<https://reviews.apache.org/r/53610/#comment225570>

    "an executor knows what a task means"?



docs/health-checks.md (line 54)
<https://reviews.apache.org/r/53610/#comment225571>

    s/and/and to/



docs/health-checks.md (line 56)
<https://reviews.apache.org/r/53610/#comment225572>

    s/only reference/only the reference/



docs/health-checks.md (line 67)
<https://reviews.apache.org/r/53610/#comment225573>

    s/docker/Docker/g



docs/health-checks.md (line 91)
<https://reviews.apache.org/r/53610/#comment225574>

    s/Field `scheme`/The `scheme` field/? I'm not really sure about this one.



docs/health-checks.md (line 101)
<https://reviews.apache.org/r/53610/#comment225576>

    Don't they always enter the network namespace?



docs/health-checks.md (line 123)
<https://reviews.apache.org/r/53610/#comment225578>

    I'd write something like:
    
    "The task is probed using Mesos' `mesos-tcp-connect` binary, which tries to establish
a TCP connection to `<host>:port`.



docs/health-checks.md (line 128)
<https://reviews.apache.org/r/53610/#comment225579>

    `The health check is considered successful if the connection can be established.` ?



docs/health-checks.md (line 130)
<https://reviews.apache.org/r/53610/#comment225580>

    Same as in the previous case, it might be clearer to say that it will always enter the
task's net ns.



docs/health-checks.md (line 161)
<https://reviews.apache.org/r/53610/#comment225581>

    s/docker/Docker/ =)



docs/health-checks.md (line 200)
<https://reviews.apache.org/r/53610/#comment225582>

    s/Boolean/The boolean/



docs/health-checks.md (line 204)
<https://reviews.apache.org/r/53610/#comment225583>

    s/as first/as a first/ ?



docs/health-checks.md (line 211)
<https://reviews.apache.org/r/53610/#comment225584>

    s/with `healthy` bit/with the `healthy` field/



docs/health-checks.md (lines 212 - 213)
<https://reviews.apache.org/r/53610/#comment225585>

    ```
    The executor will kill the task after a number of consecutive failures defined in the
`consecutive_failures` field of the `HealthCheck` protobuf
    ```?



docs/health-checks.md (line 226)
<https://reviews.apache.org/r/53610/#comment225586>

    s/istance/instance/
    s/passes health/passes the/



docs/health-checks.md (line 227)
<https://reviews.apache.org/r/53610/#comment225587>

    s/paramteres/parameters/



docs/health-checks.md (line 228)
<https://reviews.apache.org/r/53610/#comment225588>

    s/about/of/
    s/in task's/in the task's/



docs/health-checks.md (line 231)
<https://reviews.apache.org/r/53610/#comment225589>

    command or binary?



docs/health-checks.md (line 233)
<https://reviews.apache.org/r/53610/#comment225590>

    s/thing/things/



docs/health-checks.md (line 234)
<https://reviews.apache.org/r/53610/#comment225591>

    s/appropiate/the appropriate/



docs/health-checks.md (line 235)
<https://reviews.apache.org/r/53610/#comment225592>

    `with the` or `as the`?



docs/health-checks.md (line 237)
<https://reviews.apache.org/r/53610/#comment225593>

    s/docker/the Docker/



docs/health-checks.md (line 238)
<https://reviews.apache.org/r/53610/#comment225594>

    s/^/by /



docs/health-checks.md (lines 242 - 243)
<https://reviews.apache.org/r/53610/#comment225595>

    s/docker/the Docker/
    s/mesos/the Mesos/



docs/health-checks.md (line 266)
<https://reviews.apache.org/r/53610/#comment225596>

    s/depend on/rely on the presence of a/


- Gastón Kleiman


On Nov. 9, 2016, 5:05 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53610/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 5:05 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, Neil Conway, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5597
>     https://issues.apache.org/jira/browse/MESOS-5597
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md PRE-CREATION 
>   docs/home.md a5811480de050352dca6c0f7e4e64d3d2351c2d5 
> 
> Diff: https://reviews.apache.org/r/53610/diff/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/rukletsov/7200c36b2fd1e81f78f2583e68b31fd1
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message