mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <armand.gril...@gmail.com>
Subject Re: Review Request 53559: Transformed env variable parsing into Flags in process.cpp.
Date Wed, 09 Nov 2016 20:26:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53559/
-----------------------------------------------------------

(Updated Nov. 9, 2016, 8:26 p.m.)


Review request for mesos and Joseph Wu.


Changes
-------

Updated comment for libprocess port and the `advertise_port` cannot be 0 anymore.


Bugs: MESOS-4609
    https://issues.apache.org/jira/browse/MESOS-4609


Repository: mesos


Description (updated)
-------

Environment variables LIBPROCESS_ + (IP, ADVERTISE_IP,PORT,
ADVERTISE_PORT) are now in a Flags object.


Diffs (updated)
-----

  3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d 

Diff: https://reviews.apache.org/r/53559/diff/


Testing
-------

make check (macOS)


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message