mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 53610: Added health checks documentation.
Date Wed, 09 Nov 2016 17:32:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53610/#review155454
-----------------------------------------------------------




docs/health-checks.md (line 6)
<https://reviews.apache.org/r/53610/#comment225428>

    Is `Health Checking For Tasks` a better title?



docs/health-checks.md (line 8)
<https://reviews.apache.org/r/53610/#comment225429>

    `misbehave, or become unresponsive` should be `misbehave or become unresponsive`?



docs/health-checks.md (line 10)
<https://reviews.apache.org/r/53610/#comment225427>

    Use `https://github.com/mesosphere/marathon/blob/v1.3.6/docs/docs/health-checks.md` would
be shorter?



docs/health-checks.md (line 29)
<https://reviews.apache.org/r/53610/#comment225430>

    s/functionality/functionalities/g



docs/health-checks.md (line 53)
<https://reviews.apache.org/r/53610/#comment225431>

    Should remove `---` in this line?


- haosdent huang


On Nov. 9, 2016, 5:05 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53610/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 5:05 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, Neil Conway, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5597
>     https://issues.apache.org/jira/browse/MESOS-5597
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md PRE-CREATION 
>   docs/home.md a5811480de050352dca6c0f7e4e64d3d2351c2d5 
> 
> Diff: https://reviews.apache.org/r/53610/diff/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/rukletsov/7200c36b2fd1e81f78f2583e68b31fd1
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message